Add a bool flag to use ability's minimum damage for Unit Flag damage preview #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow minimum damage rather than maximum damage.
Iridar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #579
Adds a bool flag to force UIUnitFlagManager to use ability's min damage over max damage for the on-the-flag damage preview.
I don't think a hook/event is warranted.
The diff looks uglier than it should, I pretty much just made:
if (bool_flag) { new logic } else { original logic }Did a brief test, seemed to work as intended for both targeted and mouse-hover melee abilities.