Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make X2Effect_BonusWeaponDamage show bonus damage only if it's actually going to be added #1284

Merged

Conversation

Iridar
Copy link
Contributor

@Iridar Iridar commented Oct 29, 2023

Fixes #612

@Iridar Iridar added this to the 1.27.0 milestone Oct 29, 2023
@Iridar Iridar self-assigned this Oct 29, 2023
@Iridar
Copy link
Contributor Author

Iridar commented Oct 29, 2023

Tested, works.

@Iridar Iridar merged commit c1dde05 into X2CommunityCore:master Oct 29, 2023
4 checks passed
@Iridar Iridar deleted the 612-fix-bonus-weapon-damage-preview branch October 29, 2023 10:47
@Iridar
Copy link
Contributor Author

Iridar commented Feb 27, 2024

This PR caused a bug so I've reverted it for 1.27.1. See #1289 for context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conventional weapon breakthrough interacts badly with Psi Amps
2 participants