Updated Lure status effect so it ticks properly & isn't removed when the source unit dies #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackDog86
added
bug-basegame
ready-to-review
|
Tested and now ticks properly - this issue is only visible under fairly niche circumstances - the base game ships this ability as a passive (not a debuff), so even with YAF1 / show more debuff mods, the number of turns isn't displayed. The "Lost Lure Status Icon" mod changes this status effect to an ePerk_Penalty, making the number of turns then visible in YAF1 & exposing the fact that it doesn't actually tick properly under normal circumstances. I've adjusted the display in the PR to ePerk_Penalty as well so it's more transparent to the user. |
BlackDog86
force-pushed
the
1286-Fix-Ultrasonic-Lure-Duration
branch
3 times, most recently
from
2783a4b
to
7548424
Compare
Iridar
requested changes
Feb 27, 2024
| @@ -2486,8 +2486,8 @@ static function X2Effect_Persistent CreateUltrasonicLureTargetStatusEffect() | |||
| UltrasonicLureTargetEffect = new class'X2Effect_Persistent'; | |||
| UltrasonicLureTargetEffect.EffectName = default.UltrasonicLureName; | |||
| UltrasonicLureTargetEffect.DuplicateResponse = eDupe_Ignore; | |||
| UltrasonicLureTargetEffect.BuildPersistentEffect(default.ULTRASONICLURE_TURNS,, true); | |||
| UltrasonicLureTargetEffect.SetDisplayInfo(ePerkBuff_Passive, default.UltrasonicLureFriendlyName, default.UltrasonicLureFriendlyDesc, "img:///UILibrary_PerkIcons.UIPerk_mark" ); | |||
| UltrasonicLureTargetEffect.BuildPersistentEffect(default.ULTRASONICLURE_TURNS,false,false,,eGameRule_PlayerTurnBegin); //Issue #1286 - Keep effect when source dies, tick on turn begin. Adjust icon and displayinfo to display as debuff rather than passive. | |||
There was a problem hiding this comment.
Please use Start Issue and End Issue tags when changes span multiple lines, and please add a HL-Docs ref:bugfixes entry.
…ff_Penalty so number of turns is properly displayed and updated the perk icon to be more sensible.
BlackDog86
force-pushed
the
1286-Fix-Ultrasonic-Lure-Duration
branch
from
884afd1
to
291c719
Compare
|
Docs tags updated |
Iridar
approved these changes
Feb 27, 2024
Iridar
added
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1286