-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Stun Lance to target Mind Controlled units #1314
Conversation
ad5fa97
to
48a3a9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% comfortable changing a function that could be potentially getting used by mods to create their own versions of Stun Lance where the changed behavior may or may not be necessary. This change is on the edge between a bugfix and a BC break.
OTOH TreatMindControlledSquadmateAsHostile
is a really weird flag you would expect to be true
by default.
|
||
/// HL-Docs: ref:Bugfixes; issue:1312 | ||
/// Allow Stun Lance to target Mind Controlled units (currently on the same team as the Stun Lancer) | ||
TargetPropertyCondition.TreatMindControlledSquadmateAsHostile = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an empty line after this.
48a3a9b
to
344f5c7
Compare
I expect this PR to have the same merge conflict as #1313, the project file changes all landed on the same line in alphabetical order. Therefore I'd wait for that one to be merged first. |
I'll also repeat here the consideration I brought up on Discord: I'm not completely sure if there's a mod compatibility risk related to AI. For example, let's say there's a Sectoid and Stun Lancer in play. Sectoid Mind Controls an XCOM soldier. Before the fix, the same XCOM soldier is not a valid target for Stun Lance, but after the fix, it is. Testing this in a vanilla game both with and without highlander, and verifying the available moves with x2allowselectall, I found that the Lancer will not attack the mind controlled target even if it has the option to do so. But if this feels like it'd cause unwanted changes downstream, I'm not bummed if this PR gets rejected. After all the situation where the player would get burnt by this interaction is very niche; take 2 MCs (one of which is a Lancer) and make them fight against each other. |
344f5c7
to
7bd102b
Compare
Fixes #1312