Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hit results other than eHit_Success to display flyovers when using bCombineFlyovers #1321

Merged
merged 1 commit into from
May 1, 2024

Conversation

Iridar
Copy link
Contributor

@Iridar Iridar commented Mar 25, 2024

Fixes #1320

…eHit_Success` to display flyovers when using bCombineFlyovers
@Iridar Iridar added this to the 1.28.0 milestone Mar 25, 2024
@Iridar Iridar self-assigned this Mar 25, 2024
@Iridar Iridar added the ready-to-review A pull request is ready to be reviewed label Mar 25, 2024
@Iridar
Copy link
Contributor Author

Iridar commented Mar 25, 2024

I'm putting ready-to-review on this out of courtesy in case someone wants to take a look, but realistically I'll probably just merge it when the time comes for the new release.

@Iridar
Copy link
Contributor Author

Iridar commented May 1, 2024

This PR allows crits to display, but misses/grazes/etc will still not show, that would require separate handling.

@Iridar Iridar merged commit 0463673 into X2CommunityCore:master May 1, 2024
4 checks passed
@Iridar Iridar deleted the 1320-fix-bCombineFlyovers branch May 1, 2024 07:35
@Iridar Iridar added ready-for-merge the pull request was reviewed and is ready to be merged. and removed ready-to-review A pull request is ready to be reviewed labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-basegame ready-for-merge the pull request was reviewed and is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X2Action_ApplyWeaponDamageToUnit::bCombineFlyovers incorrectly handles hit results
2 participants