Dev/update notebook example #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purg
force-pushed
the
dev/update-notebook-example
branch
8 times, most recently
from
c33eb79
to
fa6bdb1
Compare
Purg
commented
Jun 4, 2021
brianhhu
reviewed
Jun 4, 2021
brianhhu
reviewed
Jun 4, 2021
brianhhu
reviewed
Jun 4, 2021
brianhhu
reviewed
Jun 4, 2021
brianhhu
reviewed
Jun 4, 2021
brianhhu
reviewed
Jun 4, 2021
brianhhu
reviewed
Jun 4, 2021
brianhhu
reviewed
Jun 4, 2021
Purg
force-pushed
the
dev/update-notebook-example
branch
2 times, most recently
from
533f614
to
3f1a40f
Compare
brianhhu
reviewed
Jun 4, 2021
brianhhu
reviewed
Jun 4, 2021
Purg
force-pushed
the
dev/update-notebook-example
branch
from
3f1a40f
to
d73c40c
Compare
|
If we're all happy enough with the change in narrative with the current notebook state, I'll squash the change so that there is just one commit (one "update" of the notebook). |
|
LGTM, feel free to squash if they're aren't any other objections. |
I just have to now fix my blob size issue, and then I'll be GTG for a merge baring further objection. |
Purg
force-pushed
the
dev/update-notebook-example
branch
2 times, most recently
from
e752ad5
to
cad2a8c
Compare
Oh! Right, depending on #9. Will mark as draft until that gets merged. Forgot to do that. |
Includes new unittest for super-type impl-getting success. This exercises the previously missed error-path due to incorrect plugin module.
Fix lack of Imagenet normalization before entering network prediction. We adjust here the narrative of the notebook example to show more explicit the "application" context and show the execution of the "application" with different inputs, rendering the appropriately different outputs. Test change in notebook narrative
Purg
force-pushed
the
dev/update-notebook-example
branch
from
cad2a8c
to
a208db9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the occlusion saliency example notebook for flow and demo-ability.
This also fixes an issue with the sliding window perturb-er plugin, whose module path was not changed when the file was renamed.
NOTE: This is currently a franken-branch that is based on (read: requires)
#6and #9.