impr: Add -R option to modify row format
#896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also leaves the option open to use different characters, but I wasn't sure if it was desirable to also add other options. I mainly just wanted box drawing support to look nice :p |
|
Thank you for your PR! This looks pretty nice, I think I would rather have the box characters by default and remove the old style rather than introduce an option. AFAIK, there's no compatibility concern with use of these characters. |
|
So just, replacing the original characters with box drawing? |
|
Welp, here it is :p I made it an option as initially I was unsure if it was even a desirable thing. I guess I did finally get my feet into Rust and learn a few things. |
|
@XAMPPRocky is this alright? |
|
Yep, LGTM! Thank you for your PR, and congrats on your first contribution! 🎉 |
CIAvash
pushed a commit
to CIAvash/tokei
that referenced
this pull request
Aug 14, 2022
kornysietsma
pushed a commit
to kornysietsma/tokei
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request here, and my first time ever using Rust, so please let me know if I did anything wrong / something could be improved. Closes #895.
Default output (unchanged):
Box drawing option: