Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kobo Libra H2O touch rotated and partly unreachable #882

Closed
cmoetzing opened this issue Mar 5, 2022 · 2 comments · Fixed by #889
Closed

Kobo Libra H2O touch rotated and partly unreachable #882

cmoetzing opened this issue Mar 5, 2022 · 2 comments · Fixed by #889
Labels

Comments

@cmoetzing
Copy link
Contributor

XCSoar 7.23
Kobo Libra H2O

Expected behavior

Touch screen is usable.

Actual behavior

Touch input seems 90° rotated. Button shows animation for action despite touching the 90° rotated position.
Not the whole screen is reachable.

Steps to reproduce the behavior

Install XCSoar 7.23 on Kobo Libra H2O

@lordfolken lordfolken added the bug label Mar 5, 2022
@cmoetzing
Copy link
Contributor Author

cmoetzing commented Mar 12, 2022

I kind of fixed it. I changed the following ...

diff --git a/src/DisplayOrientation.hpp b/src/DisplayOrientation.hpp
index 2d6a545..86787f9 100644
--- a/src/DisplayOrientation.hpp
+++ b/src/DisplayOrientation.hpp
@@ -37,7 +37,7 @@
 #ifdef KOBO
 /* Kobo defaults to portrait */
 static constexpr DisplayOrientation DEFAULT_DISPLAY_ORIENTATION =
-  DisplayOrientation::PORTRAIT;
+  DisplayOrientation::REVERSE_LANDSCAPE;
 #else
 /* everything else defaults to landscape */
 static constexpr DisplayOrientation DEFAULT_DISPLAY_ORIENTATION =

... and then it works. This change will break any other Kobo though?
I also added the Libra H2O to Model.hpp/.cpp and treat it like the Clara HD (similar hardware), so DetectKoboModel() can be used. Any help or hint highly appreciated.

https://github.com/cmoetzing/XCSoar/tree/kobo-libra-h2o

@cmoetzing
Copy link
Contributor Author

I think I found a solution. PR #889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants