Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind arrow infobox not updating according to heading variations #914

Closed
ulipo opened this issue Apr 25, 2022 · 1 comment · Fixed by #936
Closed

Wind arrow infobox not updating according to heading variations #914

ulipo opened this issue Apr 25, 2022 · 1 comment · Fixed by #936
Labels
Milestone

Comments

@ulipo
Copy link
Contributor

ulipo commented Apr 25, 2022

XCSoar versions having and not having the problem

7.12 and newer (tested on Kobo Touch and WIN64).
Works as expected on 7.11 and older.

Expected behavior

When the aircraft changes heading, the wind arrow infobox should update to show the relative wind direction (with aircraft nose pointing to the top of the screen)

Actual behavior

The arrow always stays in the same position, even if the numerical values may change; the arrow direction changes only when you touch/interact with the infobox.

Steps to reproduce the behavior

Start a SIM flight, set some values for wind (I used 5 Kt and 90°), make the aircraft do some turning and see the wind arrow remaining the same.
Touch the infobox to see that the arrow direction updates correctly once.
Rinse and repeat.

Do you have any idea what may have caused this?

I thought it could have something to do with this lines in the changelog:
Kobo
throttle sensor-triggered screen updates
improve performance of graphical InfoBoxes

but it does the same also on windows version, so I have no clue...

Do you have an idea how to solve the issue?

No idea :-(
IANAC but I can try to do my best if someone point me in the right direction...

@scls19fr
Copy link
Contributor

scls19fr commented Apr 30, 2022

Wind arrow is updated when clicking on info box and when wind is changing but not at fixed time interval (like Next arrow)

Tested with XCSoar 7.23

@lordfolken lordfolken added this to ToDo in UI Improvements May 2, 2022
fb referenced this issue May 30, 2022
This commit adds a kind of serial number or digest number which
identifies the current contents; if that number doesn't change, the
buffer doesn't need to be redrawn.

This is mostly important on the Kobo when a fast vario is connected;
it will trigger lots of redraws, and the Kobo is very slow at updating
the screen.

Closes #297
Closes #665
@lordfolken lordfolken added this to the v7.24 milestone May 30, 2022
styblope added a commit to styblope/XCSoar that referenced this issue May 31, 2022
styblope added a commit to styblope/XCSoar that referenced this issue May 31, 2022
styblope added a commit to styblope/XCSoar that referenced this issue May 31, 2022
lordfolken pushed a commit to lordfolken/XCSoar that referenced this issue May 31, 2022
The wind arrow angle inside the Wind Arrow infobox is not being updated on heading variations because the arrow re-paint function is not continuously being triggered by changes in heading. The patch adds the missing heading change triggers - both for measured heading (via `heading_available`) and computed heading based on track data (via `track_available`).

Fixes XCSoar#914
@lordfolken lordfolken moved this from ToDo to Done in UI Improvements Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants