France airspace 2021-05

[scls19fr]

Helps #210

[lordfolken]

@rawtaz has contacted john leibacher, to upload the patched variant to soaringweb. He is also trying to fix the original source on the ffvp website.

[scls19fr]

thanks because fall and winter are good seasons to learn student pilots to use XCSoar.
And it doesn't give a good feeling when downloading automatically airspace fails.

[scls19fr]

Do you know if Commission Espace Aérien of FFVP have been informed (in order to fix on their side new files)?

[mlep]

I have just contacted John Leibacher.

Little hope from FFVP: they were contacted for previous bugs in the airspace file, but no action followed... 😞

[scls19fr]

Umh! John Leibacher will receive a lot of emails. Sorry about that.
Message also transfered to commission.espaceaerien at ffvp.fr

[mlep]

Let's if FFVP reply!
(they do not monitor the French forum about airspaces?!?)

[rawtaz]

@mlep When you contacted John, did you give him the following URL? #210

FWIW, I never sent the mail, since @mlep had already contacted John. Nor did I mail commission.espaceaerien at ffvp.fr since @scls19fr apparently did that.

Guys, let us know when you get a response! And perhaps next time check if others already sent the mails :-)

[scls19fr]

@rawtaz @mlep could you send me your email?
John did a fix and want me (us?) to have a look before putting it on SoaringWeb server
I sent by email to John and to FFVP link to #210

[scls19fr]

Président de la commission Espace Aérien FFVP answered me. I can transfer you his email.
He answered me that it should be fixed in the next release of this file but they will have to also check with Naviter if these changes will be also compatible with .cup version for SeeYou

[mlep]

I am looking at the fix by John (got it directly via email).
Good that the FFVP is going to provide a fix too.

[mlep]

The new file from John is working in XCSoar 7.20.
By the way: currently, http://bobcrn.free.fr/France_21-5new.txt gives a 404 error.
So, I guess this patch will need to be altered once John updates the file https://soaringweb.org/Airspace/FR/France-21-05.txt (usually, John changes the name of a file if it is modified).

[scls19fr]

Bob (from volavoile.net forum) also published a new fixed version

Unfortunately it's currently strangely named.

https://www.volavoile.net/index.php?showtopic=13967&st=0&p=123457#entry123457

[lordfolken]

Having additional copies doesnt fix the issue.

[mlep]

@scls19fr Yes, it looks like it is the file from June 2021.
Note: John Leibacher's file contains additional fixes, that he propagates from FFVP's file to FFVP's file. So, in the long term, the file published on SoaringWeb seems the way to go for XCSoar's direct download.
Well, except if the FFVP decides to implement the corrections once and for all 😉 . Maybe you can drop a message to the Président de la commission Espace Aérien FFVP? Hopefully you will be able to convince him. Additional issue: the FFVP file is on a google drive, which makes it cumbersome/difficult/impossible to direct download. 😢

@lordfolken With the publication of the corrected file on SoaringWeb (and we should not have to wait for too long --- John has been quite reactive), the copy downloaded directly from XCSoar will be the good one.

[rawtaz]

Yeah, let's keep things simple. You two guys are well in the works of getting a proper and parsable file published on soaringweb. Let's wait for that, update and this PR if the filename changes, and be done with it :)

[mlep]

@scls19fr It looks like I cannot alter your commit (probably to be expected, but I am not so used with git(hub) ).
The proper URL is now: https://soaringweb.org/Airspace/FR/France-21-05bis.txt
(Thank you John!)

[lordfolken]

While i disagree with the comment in the airspace file "pour un problème de XCSoar." i'm happy that the file has been fixed and is now according to the standard.

[lordfolken]

Please in the future: more descriptive commit messages, and please check the "allow maintainer edits" option in the pr.
Thank you everyone involved.

[mlep]

@lordfolken I am not sure to understand why you closed this PR.
Doesn't https://soaringweb.org/Airspace/FR/France-21-05bis.txt need to be set in the file data/airspace.json first?
(I was expecting @scls19fr to do so soon)

[scls19fr]

I was quite busy today disassembling some gliders, having also our yearly end of season meal, and couldn't help here

Sorry about commit message and not allowing edit in this PR.

Thanks for the fix.

[lordfolken]

@lordfolken I am not sure to understand why you closed this PR. Doesn't https://soaringweb.org/Airspace/FR/France-21-05bis.txt need to be set in the file data/airspace.json first? (I was expecting @scls19fr to do so soon)

Unfortunatly wihtout maintainer edit i couldn't edit this pr and change the url.
So i pulled @scls19fr repo to mine

$ git remote add scsls19fr git@github.com:scls19fr/xcsoar-data-repository.git

Pulled his branch into master

$ git pull scsl19fr patch-1

Edited the airspace.json to point to the correct url.
Amended the commit:

$ git add data/airspace.json
$ git commit --amend

$ push the commit with force

$ git push -f origin

So now the commit is labeled as @scls19fr and mine.
89683e4

I like to give credit where its due. ;) and therefore i closed this pr.

[scls19fr]

Thanks @lordfolken
I still need to improve my "gitfu" (ie the art of mastering git and also Github)