Issue #217 Fix to eliminate re-counting of retried test cases, and append "retry iteration #" on names of retried tests #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylervick
reviewed
Dec 17, 2021
There was a problem hiding this comment.
Thank you for this @ssharma0312! Would you mind updating the test sample generation & test scripts to cover this as well?
I'm also wondering if these changes need to be upstream in https://github.com/davidahouse/xcresultkit
prepareTestResults.sh
Outdated
Comment on lines
13
to
25
| #xcodebuild test \ | ||
| # -project SampleApp.xcodeproj \ | ||
| # -scheme MainScheme \ | ||
| # -destination 'platform=iOS Simulator,name=iPhone 8,OS=latest' \ | ||
| # -test-iterations 5 \ | ||
| # -retry-tests-on-failure \ | ||
| # -resultBundlePath "$FILENAME" || true | ||
| echo "Even if some test failed this is OK." | ||
| echo "${FILENAME} should contain succeed, failed and skipped tests for xchtmlreport functional testing" | ||
| rm -rf "../Tests/XCTestHTMLReportTests/${FILENAME}" | ||
| mv "$FILENAME" "../Tests/XCTestHTMLReportTests/" | ||
| echo "$(tput setaf 2)$(basename "$0") successfully finished$(tput sgr 0)" No newline at end of file | ||
| echo "$(tput setaf 2)$(basename "$0") successfully finished$(tput sgr 0)" |
There was a problem hiding this comment.
I think this should be reverted :)
There was a problem hiding this comment.
@tylervick - If you just pass flags -retry-tests-on-failure and test-iterations 5, then XCode 13 will re-run failed test until they pass for a max of 5 times. I have updated the prepareTestResults script file to reflect same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #217
#217
Fix will include:
All = Total Unique Tests (Same as XCode)
Passed = Passed + Mixed (These tests may have failed but passed on retry, they are categorized as Mixed in XCode)
Failed = Total Unique Failed Tests (It won't count retried tests)
As now you can see we match closely with XCode pattern.