Show download link for other attachment mime types #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently any attachments that don't fall into existing types (video, image, text-encoded) won't display in the report.
Even worse, the activity will still be displayed but expanding the activity shows nothing.
Changes
Adding rudimentary support for "other" file type attachments
When selected, "other" file types will display a download link in the preview pane
Inline attachments are still a bit tricky since we need to know the mime type in order to encode and download. This change includes "zip" by default (per my use case).
Ultimately,
AttachmentTypeshould be replaced with Apple'sUTType.