Add parallel test processing #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
tylervick
approved these changes
Oct 6, 2023
|
|
||
| operationQueue.waitUntilAllOperationsAreFinished() | ||
|
|
||
| testSummaries = summaries.sorted { $0.testName < $1.testName } |
There was a problem hiding this comment.
Do you know if this is significantly different from today's behavior? More just to determine if the next release should denote this as a breaking change.
|
Thank you for the contribution! Just one minor question |
|
@tothszabi Thanks for addressing this! I noticed this problem on my side as well. Any updates on getting this merged in? |
|
I'll look into getting this merged - CI actions are broken due to a regression on GitHub's macOS hosted runners after Ventura. I'll verify the change locally and merge this in later on today if all looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #333
This PR adds parallel test processing by utilising a simple
OperationQueue.The concurrent operation count is set twice the time of the available CPU cores. As far as I know the
OperationQueuehas some internal max limits and so it is not too much of a problem if we set a higher value.Also the the final array has to be sorted because of the order will be random for every html generation because of the multithreading.