Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost TMP reference on the new version? #125

Closed
psarras opened this issue Feb 26, 2021 · 14 comments
Closed

Lost TMP reference on the new version? #125

psarras opened this issue Feb 26, 2021 · 14 comments
Labels
bug Something isn't working

Comments

@psarras
Copy link

psarras commented Feb 26, 2021

I think this must be due to this commit:

4ea5168

Trying to update today and it was missing TMP references

image

@monitor1394
Copy link
Collaborator

I fixed it in master.
Given that TMP is not enabled by default, so asmdef does not added a reference to TMP at first, but automatically added when TMP enabled.

@psarras
Copy link
Author

psarras commented Feb 26, 2021

Awesome will try it on Monday! Cheers!

@monitor1394 monitor1394 added the bug Something isn't working label Mar 1, 2021
@psarras
Copy link
Author

psarras commented Mar 2, 2021

Hey! I think there is an unforeseen bug here. The button Enable TMP will not work if you have compile errors. An while updating, I am removing and adding the library, which causes to have compile errors since the moment the package comes in doesn't have any references to TMP. Is there a way to import it directly with TMP, or avoid having those temporary compile errors?

So actually the errors were the original ones on this post. I am trying this version.

image

I upgrade. Then I get a few errors, which are to be expected, because I have the symbol dUI_TextMeshPro but I don't have the assembly. I remove the symbol and apply. Then I have no errors but I have no TMP either. So I simply press the UI button Enable TMP from XCharts. This adds the Symbol but not the TMP reference. Which gives me these errors:

image

@monitor1394
Copy link
Collaborator

You need to work out those compilation errors yourself.

Manually remove dUI_TextMeshPro:
image

When the compilation is successful, you can press the UI button Enable TMP to import TMP again.

@psarras
Copy link
Author

psarras commented Mar 2, 2021

Hey @monitor1394 I've updated my comment. The errors are from the library. I did as you said! Cheers.

@monitor1394
Copy link
Collaborator

I have pushed the modification of master to the 2.0-UPM branch, and the test is OK.

@psarras
Copy link
Author

psarras commented Mar 2, 2021

Works as expected! Awesome work 👍

@psarras
Copy link
Author

psarras commented Mar 2, 2021

Ok this works on my machine quite well and I can build. However when I try this project on a CI/CD pipeline I get the same errors. I guess this is because I need to call the TextMeshPro Enable before compiling, in order to get the TMP reference. Is there a way to do that you think?

@monitor1394
Copy link
Collaborator

See if I understand you right:
The project on CI/CD is the same git or SVN as your local project. Then you push the projectSetting.asset with the DUI_TextMeshPro. But ASMDEF can't synchronize.
The result is that the project found on the CI/CD requires TMP but the local ASMDEF does not have a reference to TMP.
Is that right?

If so, there seems to be a problem. Do you have any suggestions?

@psarras
Copy link
Author

psarras commented Mar 2, 2021

Yep that is correct. I haven't thought any satisfactory solution yet I am afraid.

I can include this library in my Assets folder and then I would be able to push the right ASMDEF but this is not pretty. Or I can fork it and include on the fork this reference again.

Is there a way to have multiple package releases, one with TMP and one without? But this also sounds weird. It needs more investigation from my end at least.

@monitor1394
Copy link
Collaborator

I haven't thought any satisfactory solution yet.

I also think this is an option:

Is there a way to have multiple package releases, one with TMP and one without?

@cLick1338
Copy link

Reiterating the solution that worked for me in case other people need it: (Local editor and build, not using CI/CD)
Project Settings -> Player : Scripting Define Symbols -> Remove dUI_TextMeshPro
XCharts dropdown menu (top of Unity window) -> TextMeshPro Enable

@nixcry
Copy link

nixcry commented Apr 23, 2021

Still have this issue with XCharts v2.1.1
Environment:
Unity 2019.4.11,
TextMeshPro 2.1.6
Unity UI 1.0.0

Solution:
Fell back to XCharts v2.0.0, the problem fixed, working with TextMeshPro again.

I think this must be due to this commit:

4ea5168

Trying to update today and it was missing TMP references

image

@JimZeeKing
Copy link

Still have this issue with XCharts v2.1.1
Environment:
Unity 2019.4.11,
TextMeshPro 2.1.6
Unity UI 1.0.0

Solution:
Fell back to XCharts v2.0.0, the problem fixed, working with TextMeshPro again.

I think this must be due to this commit:
4ea5168
Trying to update today and it was missing TMP references
image

Same for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants