Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LargestPeakProperties does not return position #104

Closed
JelleAalbers opened this issue May 21, 2017 · 1 comment
Closed

LargestPeakProperties does not return position #104

JelleAalbers opened this issue May 21, 2017 · 1 comment
Labels

Comments

@JelleAalbers
Copy link
Contributor

Since LargestPeakProperties is missing 'peaks.reconstructed_positions*' in its extra_branches list, its code for finding peak positions (https://github.com/XENON1T/hax/blob/master/hax/treemakers/common.py#L244) never succeeds. Consequently the branches s2_x etc. created by this treemaker are always nan.

Incidentally, this minitree has some branches that clash with Basics (e.g. s2_area_fraction_top), but they do not have the same meaning (in Basics the s2 refers to the main S2, in LargestPeakProperties the largest S2).

@feigaodm
Copy link
Member

feigaodm commented May 22, 2017

Thanks for noticing this bug. Will fix it before releasing new hax. Fixed in PR(#102)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants