-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sideband unblinding for AC+Wall model #199
Conversation
It's too difficult to review it:) Can you try to modify it this way: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides that, we shall unblind signals with S2 between 150PE and 200PE
@feigaodm I've implemented your requests. Also, just additionally unblinded |
(already unblinded before this PR)
I like the reorganization but considering the confusion we had recently do we want to consider making it more clear that these options shouldn't be touched? Like, we had more than one analyst (non-maliciously) modifying something called 'blinding_cut'. So that strategy was already a cause for confusion apparently. Now we have a bunch of "unblind_*" options... which at first glance are far more confusing. Do you think it's possible to put all the blinding options in a separate section or file clearly delineated as 'do not touch' and not modifiable in override via hax.init? |
Following #208
This PR unblinds the sideband below the red line and
cs1 = 200 pe
in the following image, first defined in #168: