-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variables to reject abnormal noise #255
base: master
Are you sure you want to change the base?
Conversation
Flake8 detected 6 issues on 6765d95 posted by Sider |
hax/treemakers/common.py
Outdated
branch_selection = ['n_hits_rejected*', 'lone_hits_per_channel_before*', 'lone_hits_per_channel*'] | ||
|
||
def __init__(self): | ||
hax.minitrees.TreeMaker.__init__(self) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8] [F821] undefined name 'hax' (link)
posted by Sider
hax/treemakers/common.py
Outdated
@@ -22,6 +22,47 @@ def extract_data(self, event): | |||
return dict(event_time=event.start_time, | |||
event_duration=event.stop_time - event.start_time) | |||
|
|||
class NoiseRejection(TreeMaker): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Flake8] [E302] expected 2 blank lines, found 1 (link)
posted by Sider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, this only adds an extra treemaker without affecting anything else. I removed the accidental bump of the Extended version, leftover from the earlier implementation.
motivated by lowE ER groups analysis