Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Deprecate the usage of XENONnT/ax_env #432

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Deprecate the usage of XENONnT/ax_env #432

merged 2 commits into from
Apr 22, 2024

Conversation

dachengx
Copy link
Contributor

@dachengx dachengx commented Feb 11, 2024

What is the problem / what does the code in this PR do

Use base_environment for pytest, following XENONnT/base_environment#1487.

WFSim needs you:

  • Please add a test for this PR, as a bare minimum, make sure it's covered in coveralls!
  • Can you add a docsting to all your functions?

Pay attention:

  • Due to databases being needed for testing, making a PR from your own fork will typically NOT run the tests. If you then merge master might break

@dachengx dachengx marked this pull request as ready for review February 21, 2024 15:15
@coveralls
Copy link

Coverage Status

coverage: 82.67% (-0.1%) from 82.78%
when pulling d079c05 on update_test
into 8180bda on master.

@dachengx dachengx merged commit ac77c4b into master Apr 22, 2024
6 checks passed
@dachengx dachengx deleted the update_test branch April 22, 2024 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants