Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a statistical model base class (under construction #7

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Adds a statistical model base class (under construction #7

merged 4 commits into from
Jun 15, 2023

Conversation

kdund
Copy link
Member

@kdund kdund commented Jun 15, 2023

Statistical model base class (should we move it up to $NAME/$NAME instead of in the subfolder likelihoods?)

@kdund kdund requested a review from hammannr June 15, 2023 13:14
@kdund kdund self-assigned this Jun 15, 2023
hammannr
hammannr reviewed Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@hammannr hammannr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @kdund ! There are a few small thinks that make it unrunnable for me but I'll have another look once those are fixed

redskink/statistical_model.py Outdated Show resolved Hide resolved
redskink/statistical_model.py Outdated Show resolved Hide resolved
redskink/statistical_model.py Outdated Show resolved Hide resolved
redskink/statistical_model.py Show resolved Hide resolved
hammannr
hammannr reviewed Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@hammannr hammannr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found two more issues with the code

redskink/statistical_model.py Outdated Show resolved Hide resolved
redskink/statistical_model.py Outdated Show resolved Hide resolved
@hammannr hammannr merged commit 4b29a2d into master Jun 15, 2023
@hammannr hammannr deleted the parent_inference_class_initial branch June 15, 2023 17:57
@hammannr hammannr mentioned this pull request Jun 21, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hammannr hammannr hammannr approved these changes

Assignees

@kdund kdund

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdund @hammannr