Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binning is not required by Component #103

Merged
merged 2 commits into from
Jun 18, 2023
Merged

Binning is not required by Component #103

merged 2 commits into from
Jun 18, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jun 18, 2023 •
edited

In some usage cases, a user wants only to simulate the templates or dataset, so binning should not be a mandatory requirement.

Should fix #102.

@github-actions
Copy link

github-actions bot commented Jun 18, 2023 •
edited

Pull Request Test Coverage Report for Build 5303960026

  • 10 of 11 (90.91%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 83.101%
Changes Missing Coverage Covered Lines Changed/Added Lines %
appletree/component.py 10 11 90.91%
Totals Coverage Status
Change from base Build 5303874937: 0.008%
Covered Lines: 1908
Relevant Lines: 2296
💛 - Coveralls

@dachengx dachengx merged commit 1376be0 into master Jun 18, 2023
7 checks passed
@dachengx dachengx deleted the no_bins_component branch June 18, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bins should not be mandatorily required by component
1 participant
@dachengx