Smarter SigmaMap handling and needed_parameters #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Pull Request Test Coverage Report for Build 6832000030
💛 - Coveralls |
|
Any idea why the doc fails? :) @dachengx |
dachengx
reviewed
Nov 11, 2023
dachengx
approved these changes
Nov 11, 2023
This was referenced Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the logic of SigmaMap. Now the value of it can be
"file_name". Then no scale factor is needed.["median_file_name", "upper_file_name", "lower_file_name"]. The scale factor is needed in parameters, with "_sigma" suffix as before.["median_file_name", "upper_file_name", "lower_file_name", "scaler_name"]needed_parametersin component is also refined. Removed unnecessary parameters.