Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S1/S2 correction and gas gain when simulating S1/S2PE #122

Merged
merged 13 commits into from
Dec 20, 2023

Conversation

mhliu0001
Copy link
Contributor

This pull request proposes two changes:

  1. Use S1/S2 correction calculated from TRUE positions rather than RECONSTRUCTED ones when we simulate PEs;
  2. Add gas gain (x, y) dependence.

Should resolve #121.

Maybe someone should update the notebooks as well. Since the notebooks contain benchmark runs, I can't update them directly.

Copy link

github-actions bot commented Nov 30, 2023

Pull Request Test Coverage Report for Build 7276943356

  • 44 of 44 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 84.188%

Totals Coverage Status
Change from base Build 7267421814: 0.2%
Covered Lines: 1970
Relevant Lines: 2340

💛 - Coveralls

@zihaoxu98
Copy link
Collaborator

Thanks @mhliu0001 Only one suggestion. I think it's better to define the gas gain map as the relative map to parameter['gas_gain']. Then the placeholder map should be all identities. Then it won't have any conflicts with previous usage.

appletree/plugins/detector.py Outdated Show resolved Hide resolved
@dachengx dachengx added the bug Something isn't working label Dec 20, 2023
@dachengx dachengx merged commit e237adf into master Dec 20, 2023
7 checks passed
@dachengx dachengx deleted the fix_correction branch December 20, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S2 simulation
3 participants