Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be compatible with JAX_ENABLE_X64=1 #134

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Be compatible with JAX_ENABLE_X64=1 #134

merged 1 commit into from
Jan 29, 2024

Conversation

dachengx
Copy link
Collaborator

The current code does not support export JAX_ENABLE_X64=1 which is a pity.

I can understand that these codes:

INT = np.int32
FLOAT = np.float32

are for memory saving, but we still should be compatible with the usage of 64 bits.

@dachengx dachengx marked this pull request as ready for review January 29, 2024 09:52
@coveralls
Copy link

coveralls commented Jan 29, 2024

Pull Request Test Coverage Report for Build 7694156133

  • 3 of 6 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 84.009%

Changes Missing Coverage Covered Lines Changed/Added Lines %
appletree/plugin.py 0 1 0.0%
appletree/randgen.py 3 5 60.0%
Totals Coverage Status
Change from base Build 7510500909: -0.06%
Covered Lines: 1970
Relevant Lines: 2345

💛 - Coveralls

@zihaoxu98 zihaoxu98 requested review from zihaoxu98 and removed request for zihaoxu98 January 29, 2024 12:43
@dachengx dachengx merged commit 4e0a334 into master Jan 29, 2024
7 checks passed
@dachengx dachengx deleted the compatible_x64 branch January 29, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants