Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise more information when file can not be found #135

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Raise more information when file can not be found #135

merged 2 commits into from
Jan 29, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Jan 29, 2024 •
edited

These are usually two cases where we can not load a map:

  1. there is no corresponding file found
  2. the format of the found file is not correct

Before this PR, there we will always show the same error for these two cases. This PR first checks the first case then the second.

@dachengx dachengx marked this pull request as ready for review January 29, 2024 09:56
@coveralls
Copy link

coveralls commented Jan 29, 2024 •
edited

Pull Request Test Coverage Report for Build 7696258360

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 84.015%
Totals Coverage Status
Change from base Build 7696255555: 0.006%
Covered Lines: 1971
Relevant Lines: 2346
💛 - Coveralls

@dachengx dachengx merged commit ac87d18 into master Jan 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihaoxu98 zihaoxu98 zihaoxu98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dachengx @coveralls @zihaoxu98