Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix when using force_no_eff with tuple data_names #141

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Bug fix when using force_no_eff with tuple data_names #141

merged 2 commits into from
Feb 16, 2024

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Feb 16, 2024 •
edited

When using force_no_eff with tuple data_names(like the test this PR modifies), an error will trigger at

appletree/appletree/component.py

Line 324 in ec57286

raise RuntimeError(f"data_names must be list or str, but given {type(data_names)}")

This PR tries to fix the bug.

@dachengx dachengx marked this pull request as ready for review February 16, 2024 10:07
@coveralls
Copy link

coveralls commented Feb 16, 2024 •
edited

Pull Request Test Coverage Report for Build 7929023938

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.007%
Totals Coverage Status
Change from base Build 7883850333: 0.0%
Covered Lines: 1975
Relevant Lines: 2351
💛 - Coveralls

@zihaoxu98 zihaoxu98 merged commit 138bb56 into master Feb 16, 2024
7 checks passed
@zihaoxu98 zihaoxu98 deleted the force_no_eff_type branch February 16, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihaoxu98 zihaoxu98 zihaoxu98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dachengx @coveralls @zihaoxu98