Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .h5 backend to store MCMC results #57

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Add .h5 backend to store MCMC results #57

merged 1 commit into from
Oct 18, 2022

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Oct 18, 2022 •
edited

  1. If the backend_h5 key is in the configuration file, will use that path to store MCMC results.
  2. If the backend_h5 key does not exist in configuration files, will store MCMC results in memory.

@dachengx dachengx changed the title Add .h5 backend to store simulation results Add .h5 backend to store MCMC results Oct 18, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3276545989

  • 14 of 20 (70.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 82.943%
Changes Missing Coverage Covered Lines Changed/Added Lines %
appletree/context.py 14 20 70.0%
Files with Coverage Reduction New Missed Lines %
appletree/context.py 1 75.74%
Totals Coverage Status
Change from base Build 3270631752: -0.1%
Covered Lines: 1274
Relevant Lines: 1536
💛 - Coveralls

@dachengx
Copy link
Collaborator Author

@xzh19980906 I guess it is good to go. But looking forward to your opinion.

zihaoxu98
zihaoxu98 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@zihaoxu98 zihaoxu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

@dachengx dachengx merged commit 7fe9ffb into master Oct 18, 2022
@dachengx dachengx deleted the emcee_backend branch October 18, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihaoxu98 zihaoxu98 zihaoxu98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dachengx @coveralls @zihaoxu98