Convert PDF spectrum to CDF by default #72
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 3733004478
💛 - Coveralls |
appletree/utils.py
Outdated
| @@ -498,3 +498,17 @@ def _add_extension(module, subclass, base): | |||
| ) | |||
| else: | |||
| setattr(module, subclass.__name__, subclass) | |||
|
|
|||
|
|
|||
| def integrate(x, y): | |||
There was a problem hiding this comment.
These functions are not necessarily being here as long as they are only used in appletree/config.py.
There was a problem hiding this comment.
Because they are some calculation but not really utilities.
There was a problem hiding this comment.
I am thinking these functions will be used for the normalization of an analytical spectrum, which will be called again somewhere in component.
There was a problem hiding this comment.
Then please rename the functions with the method(s) applied specifically. Like 'midpoint', or 'binned'.
| @@ -498,3 +498,22 @@ def _add_extension(module, subclass, base): | |||
| ) | |||
| else: | |||
| setattr(module, subclass.__name__, subclass) | |||
|
|
|||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W291 trailing whitespace
| """ | ||
| _, res = cum_integrate(x, y) | ||
| return res[-1] | ||
|
|
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W291 trailing whitespace
| @@ -498,3 +498,24 @@ def _add_extension(module, subclass, base): | |||
| ) | |||
| else: | |||
| setattr(module, subclass.__name__, subclass) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W291 trailing whitespace
| _, res = cum_integrate_midpoint(x, y) | ||
| return res[-1] | ||
|
|
||
|
|
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W291 trailing whitespace
This PR will convert the x vs PDF map to CDF vs x map by default, to facilitate energy sampler.