-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add R dimension for template generation #74
Conversation
appletree/plugins/reconstruction.py
Outdated
return key, x + delta_x, y + delta_y, z | ||
x_rec = x + delta_x | ||
y_rec = y + delta_y | ||
return key, x_rec, y_rec, z, jnp.sqrt(x_rec**2 + y_rec**2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
WPS221 Found line with high Jones Complexity: 16 > 14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xzh19980906 Better assign r_rec
first then return it.
appletree/plugins/reconstruction.py
Outdated
rec_x = x + delta_x | ||
rec_y = y + delta_y | ||
rec_z = z | ||
rec_r = jnp.sqrt(x_rec**2 + y_rec**2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F821 undefined name 'x_rec'
appletree/plugins/reconstruction.py
Outdated
rec_x = x + delta_x | ||
rec_y = y + delta_y | ||
rec_z = z | ||
rec_r = jnp.sqrt(x_rec**2 + y_rec**2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pep8] reported by reviewdog 🐶
F821 undefined name 'y_rec'
Pull Request Test Coverage Report for Build 3733139391
💛 - Coveralls |
Add rec_r in pos_rec if we wanna use binning in r