Add NESTv2 yields parameterization and literature constrain #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pep8
appletree/plugins/nestv2.py|72 col 9| WPS221 Found line with high Jones Complexity: 17 > 14
appletree/plugins/nestv2.py|83 col 49| WPS442 Found outer scope names shadowing: Nq
appletree/plugins/nestv2.py|83 col 50| N803 argument name 'Nq' should be lowercase
appletree/plugins/nestv2.py|85 col 9| WPS221 Found line with high Jones Complexity: 17 > 14
appletree/plugins/nestv2.py|107 col 13| WPS465 Found likely bitwise and boolean operation mixup
appletree/plugins/nestv2.py|108 col 18| WPS358 Found a float zero (0.0)
Pull Request Test Coverage Report for Build 4259070578
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
likelihood.LikelihoodLitthat fits literature constraints. It takes specified distribution and arguments of literature data points.config.ConstantSetthat takes keyword arguments names and values, for more flexible functions in the plugins.appletree/parameters/nestv2.json) are copied from A Comprehensive, Exhaustive, Complete Analysis of World LXe NR Data With a Final Model.appletree/instructs/literature_lyqy.json) are from 2 literatures. Qy measurements are from Low-Energy Physics Reach of Xenon Detectors for Nuclear-Recoil-Based Dark Matter and Neutrino Experiments. Ly measurements are from Low-energy (0.7-74 keV) nuclear recoil calibration of the LUX dark matter experiment using D-D neutron scattering kinematics.