Add uncertainty on electron lifetime #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4337048346
💛 - Coveralls |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
appletree/context.py
Outdated
| @@ -40,7 +40,11 @@ def __init__(self, config): | |||
|
|
|||
| self.likelihoods = dict() | |||
|
|
|||
| self.par_config = self.get_parameter_config(config['par_config']) | |||
| if not par_config is None: | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
WPS508 Found incorrect not with compare usage
appletree/context.py
Outdated
| @@ -40,7 +40,11 @@ def __init__(self, config): | |||
|
|
|||
| self.likelihoods = dict() | |||
|
|
|||
| self.par_config = self.get_parameter_config(config['par_config']) | |||
| if not par_config is None: | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
E714 test for object identity should be 'is not'
| @@ -340,6 +346,17 @@ def update_parameter_config(self, likelihoods): | |||
| self.par_config.pop(p) | |||
| return needed_parameters | |||
|
|
|||
| def set_instruct(self, instructs): | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
WPS615 Found unpythonic getter or setter
| :param instructs: dict, instruction file name or dictionary | ||
| """ | ||
| if not hasattr(self, 'instruct'): | ||
| self.instruct = dict() |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
C408 Unnecessary dict call - rewrite as a literal.
| @@ -325,7 +325,11 @@ def get_log_likelihood(self, key, batch_size, parameters): | |||
| :param batch_size: int of number of simulated events | |||
| :param parameters: dict of parameters used in simulation | |||
| """ | |||
| key, result = self._simulate_yields(key, batch_size, parameters) | |||
| if batch_size != 1: | |||
| warning = f'You specified the batch_size larger than 1, '\ | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
N400: Found backslash that is used for line breaking
zihaoxu98
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configtoinstructBandTwoHalfNormextrapolation when out of range