Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NESTv2 NR parameters of quanta distribution's width #85

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

dachengx
Copy link
Collaborator

@dachengx dachengx commented Mar 13, 2023

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

pep8

appletree/plugins/nestv2.py|177 col 10| N806 variable 'Nq' in function should be lowercase
appletree/plugins/nestv2.py|188 col 42| N803 argument name 'elecFrac' should be lowercase
appletree/plugins/nestv2.py|190 col 13| WPS221 Found line with high Jones Complexity: 16 > 14
appletree/plugins/nestv2.py|191 col 9| WPS221 Found line with high Jones Complexity: 17 > 14
appletree/plugins/nestv2.py|191 col 10| N806 variable 'Variance' in function should be lowercase
appletree/plugins/nestv2.py|202 col 42| N803 argument name 'recombProb' should be lowercase
appletree/plugins/nestv2.py|203 col 9| WPS221 Found line with high Jones Complexity: 24 > 14
appletree/plugins/nestv2.py|203 col 10| N806 variable 'widthCorrection' in function should be lowercase
appletree/plugins/nestv2.py|203 col 49| WPS204 Found overused expression: parameters['alpha2']; used 5 > 4
appletree/plugins/nestv2.py|203 col 101| E501 line too long (116 > 100 characters)
appletree/plugins/nestv2.py|204 col 9| WPS221 Found line with high Jones Complexity: 33 > 14
appletree/plugins/nestv2.py|204 col 10| N806 variable 'muCorrection' in function should be lowercase
appletree/plugins/nestv2.py|204 col 101| E501 line too long (163 > 100 characters)

appletree/randgen.py Show resolved Hide resolved
appletree/randgen.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Outdated Show resolved Hide resolved
appletree/plugins/nestv2.py Outdated Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Mar 13, 2023

Pull Request Test Coverage Report for Build 4420613809

  • 48 of 88 (54.55%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.04%) to 80.134%

Changes Missing Coverage Covered Lines Changed/Added Lines %
appletree/components/yields.py 3 6 50.0%
appletree/randgen.py 3 14 21.43%
appletree/plugins/nestv2.py 42 68 61.76%
Files with Coverage Reduction New Missed Lines %
appletree/components/yields.py 1 65.0%
Totals Coverage Status
Change from base Build 4374802690: -1.04%
Covered Lines: 1795
Relevant Lines: 2240

💛 - Coveralls

@dachengx dachengx changed the title Add NESTv2 NR quanta distribution width Add NESTv2 NR parameters of quanta distribution's width Mar 14, 2023
@dachengx dachengx marked this pull request as ready for review March 14, 2023 22:03
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
appletree/plugins/nestv2.py Show resolved Hide resolved
@dachengx dachengx requested a review from zihaoxu98 March 15, 2023 11:22
Copy link
Collaborator

@zihaoxu98 zihaoxu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks all good to me!

@dachengx dachengx merged commit 489c5e4 into master Mar 15, 2023
@dachengx dachengx deleted the nestv2_width branch March 15, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants