-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NESTv2 NR parameters of quanta distribution's width #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
pep8
appletree/plugins/nestv2.py|177 col 10| N806 variable 'Nq' in function should be lowercase
appletree/plugins/nestv2.py|188 col 42| N803 argument name 'elecFrac' should be lowercase
appletree/plugins/nestv2.py|190 col 13| WPS221 Found line with high Jones Complexity: 16 > 14
appletree/plugins/nestv2.py|191 col 9| WPS221 Found line with high Jones Complexity: 17 > 14
appletree/plugins/nestv2.py|191 col 10| N806 variable 'Variance' in function should be lowercase
appletree/plugins/nestv2.py|202 col 42| N803 argument name 'recombProb' should be lowercase
appletree/plugins/nestv2.py|203 col 9| WPS221 Found line with high Jones Complexity: 24 > 14
appletree/plugins/nestv2.py|203 col 10| N806 variable 'widthCorrection' in function should be lowercase
appletree/plugins/nestv2.py|203 col 49| WPS204 Found overused expression: parameters['alpha2']; used 5 > 4
appletree/plugins/nestv2.py|203 col 101| E501 line too long (116 > 100 characters)
appletree/plugins/nestv2.py|204 col 9| WPS221 Found line with high Jones Complexity: 33 > 14
appletree/plugins/nestv2.py|204 col 10| N806 variable 'muCorrection' in function should be lowercase
appletree/plugins/nestv2.py|204 col 101| E501 line too long (163 > 100 characters)
Pull Request Test Coverage Report for Build 4420613809
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks all good to me!
Again, following A Review of NEST Models, and Their Application to Improvement of Particle Identification in Liquid Xenon Experiments and NESTv2.3.7, add NR quanta width parameters such as fano factors.