Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate number of events in the defined ROI #88

Merged
merged 7 commits into from
Mar 22, 2023
Merged

Generate number of events in the defined ROI #88

merged 7 commits into from
Mar 22, 2023

Conversation

dachengx
Copy link
Collaborator

This feature uses the simulated histogram of templates and returns the sum of events in each likelihood.

@coveralls
Copy link

coveralls commented Mar 18, 2023 •
edited

Pull Request Test Coverage Report for Build 4483155509

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 80.249%
Totals Coverage Status
Change from base Build 4447512358: 0.1%
Covered Lines: 1808
Relevant Lines: 2253
💛 - Coveralls

@dachengx dachengx marked this pull request as ready for review March 18, 2023 03:09
@dachengx dachengx requested a review from zihaoxu98 March 18, 2023 03:09
github-actions[bot]
github-actions bot reviewed Mar 18, 2023
View reviewed changes
appletree/context.py Outdated Show resolved Hide resolved
zihaoxu98
zihaoxu98 reviewed Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@zihaoxu98 zihaoxu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "_in_hist" sounds a bit confusing. Maybe we can call it something like "num_events_accepted"?

@dachengx
Copy link
Collaborator Author

@xzh19980906 Yes I have modified that in the latest commit.

@zihaoxu98 zihaoxu98 self-requested a review March 22, 2023 05:04
@dachengx dachengx merged commit eabed7d into master Mar 22, 2023
@dachengx dachengx deleted the n_events branch March 22, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@zihaoxu98 zihaoxu98 zihaoxu98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dachengx @coveralls @zihaoxu98