codefactor complains about somehting unrelated

XENONnT · Nov 27, 2020 · 8b01a40 · 8b01a40
1 parent 432cc08
commit 8b01a40
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/straxen/analyses/waveform_plot.py b/straxen/analyses/waveform_plot.py
@@ -280,8 +280,11 @@ def plot_wf(st: strax.Context,
     :param time_fmt: format fo the timestamp (datetime.strftime format)
     :param kwargs: kwargs for plot_peaks
     """
-    p = containers  # usually peaks
 
+    if not isinstance(run_id, str):
+        raise ValueError(f'Insert single run_id, not {run_id}')
+
+    p = containers  # usually peaks
     run_start, _ = st.estimate_run_start_and_end(run_id)
     t_range = np.array([p['time'].min(), strax.endtime(p).max()])
 

diff --git a/straxen/common.py b/straxen/common.py
@@ -197,7 +197,6 @@ def get_secret(x):
             return uconfig.get('straxen', x)
         except configparser.NoOptionError:
             warn(f'uconfig does not have {x}')
-            pass
 
     # if that doesn't work, revert to xenon_secrets
     try: