Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a warning if fried rice is down insteat of crashing everything. #211

Closed
WenzDaniel opened this issue Sep 7, 2020 · 3 comments
Closed
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@WenzDaniel
Copy link
Collaborator

In our current implementation of the rundb.py straxen raises an error when fried rice is down:

~/mymodules/straxen/straxen/rundb.py in _find(self, key, write, allow_incomplete, fuzzy_for, fuzzy_for_options)
    153                         'protocol': 'rucio'}}}
    154             doc = self.collection.find_one({**run_query, **dq},
--> 155                                            projection=dq)
    156             if doc is not None:
    157                 datum = doc['data'][0]

# (some long mongo trace back)

ServerSelectionTimeoutError: fried.rice.edu:27017: timed out

This issue was introduced with https://github.com/XENONnT/straxen/pull/164/files .

In most cases analyzers will work with locally stored data and hence do not need to access anything via the rundb storage system. Hence I propose rather to throw a warning and to drop the rundb storage system from the registered storage rather than raising an error and stopping any ongoing analysis.

@WenzDaniel WenzDaniel added enhancement New feature or request help wanted Extra attention is needed labels Sep 7, 2020
ershockley added a commit that referenced this issue Sep 7, 2020
This should address #211. I have not tested it.
@WenzDaniel
Copy link
Collaborator Author

Evans PR makes this issue obsolete

@JoranAngevaare
Copy link
Contributor

@WenzDaniel #164 is not related to this issue. Rather #114 is the cull-pit.

@JoranAngevaare
Copy link
Contributor

An alternative solution is proposed in #213 using the other two mirrors as backup in order not to prevent analyzers to work outside of dali (see cited PR)

@JoranAngevaare JoranAngevaare added the bug Something isn't working label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants