Add 'electron_diffusion_cte' variable from CMT #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The longitudinal diffusion constant value was added to the CMT but not to the `single_value_corrections` list. Without it, `straxen.get_correction_from_cmt(run_id', ('electron_diffusion_cte', version, detector))` leads to an error.
Issue found by @l-althueser.
|
I would give green light for this as this is exactly the workaround that I provided. Thanks @ricmperes! Maybe some CMT expert can comment if we miss some important spot in the code, @ahiguera-mx ? |
|
As far as I know this is not use anywhere in straxen, right? but we retrieve the information via CMT therefore this patch. |
|
Right. It's only used in cutax for the S2Width cut to make it time-dependent and/or directly dependent to CMT instead of having hardcoded values (here in PR). |
|
Tagging https://github.com/XENONnT/cutax/pull/166/files for completeness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the code in this PR do / what does it improve?
The longitudinal diffusion constant value was added to the CMT but not to the
single_value_correctionslist. Without it,straxen.get_correction_from_cmt(run_id', ('electron_diffusion_cte', version, detector))leads to an error.Issue in code found by @l-althueser.
This PR adds support for
straxen.get_correction_from_cmtto fetch the diffusion constant from CMT.Can you briefly describe how it works?
Main code stays unaltered,
'electron_diffusion_cte'added to thesingle_value_correctionslist.Can you give a minimal working example (or illustrate with a figure)?
straxen.get_correction_from_cmt('17895', ('electron_diffusion_cte', 'ONLINE', 'nT'))