Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort hitlets in nVETOHitlets #1210

Merged
merged 1 commit into from Jun 27, 2023
Merged

Sort hitlets in nVETOHitlets #1210

merged 1 commit into from Jun 27, 2023

Conversation

dachengx
Copy link
Collaborator

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What does the code in this PR do / what does it improve?

In some very rare cases, the hitlets is not sorted. But then in nVETOEvents plugin, strax.touching_windows will raise error.

Can you briefly describe how it works?

Return the sorted hitlets.

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@dachengx dachengx requested a review from WenzDaniel June 26, 2023 23:51
@coveralls
Copy link

Coverage Status

coverage: 93.564% (+0.02%) from 93.542% when pulling 49bff43 on sort_hitlets into be1b81b on master.

@WenzDaniel
Copy link
Collaborator

I think they should already come sorted, but either way does not hurt to ensure.

@WenzDaniel WenzDaniel merged commit d0b935c into master Jun 27, 2023
8 checks passed
@WenzDaniel WenzDaniel deleted the sort_hitlets branch June 27, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants