Fix URLConfig.evaluate_dry #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -536,8 +535,8 @@ def evaluate_dry(cls, url: str, **kwargs): | |||
| f"Try passing {k} as a keyword argument." | |||
| f"e.g.: `URLConfig.evaluate_dry({url}, {k}=SOME_VALUE)`" | |||
| ) | |||
|
|
|||
| return cls.eval(protocol, url_arg, combined_kwargs) | |||
|
|
|||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W293 blank line contains whitespace
dachengx
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLConfig.evaluate_drywas using theurl_to_astmethod which returns a nested abstract syntax tree so only the top level kwargs were replaced. This causes errors when trying to replace kwargs used by nested protocols.The PR uses the
URLConfig.format_url_kwargswhich replaces kwargs globally in the URL.Minimal example: