Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tf_peak_model_s1_cnn to tf_model_s1_cnn #1223

Merged
merged 3 commits into from Jul 28, 2023
Merged

Conversation

dachengx
Copy link
Collaborator

What does the code in this PR do / what does it improve?

This name is following

tf_model_cnn = straxen.URLConfig(
default=f'tf://'
f'resource://'
f'cmt://{algorithm}_model'
f'?version=ONLINE'
f'&run_id=plugin.run_id'
f'&fmt=abs_path',
help='CNN model. Should be opened using the "tf" descriptor. '
'Set to "None" to skip computation',
cache=3,
)

We do not need to update the plugin version because it is lineage depends on plugin configs.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Notes on testing

  • Until the automated tests pass, please mark the PR as a draft.
  • On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

@dachengx dachengx marked this pull request as ready for review July 24, 2023 21:19
@coveralls
Copy link

coveralls commented Jul 24, 2023

Coverage Status

coverage: 93.534% (-0.01%) from 93.545% when pulling 6078a8b on tf_model_s1_cnn_name into b3e776f on master.

@dachengx dachengx removed the request for review from matteoguida July 28, 2023 12:06
@dachengx
Copy link
Collaborator Author

I will merge it. This PR WILL change the lineage. But fortunately only of peak_s1_positions_cnn.

@dachengx dachengx merged commit 71db55a into master Jul 28, 2023
7 checks passed
@dachengx dachengx deleted the tf_model_s1_cnn_name branch July 28, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants