Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing docstrings #1234

Merged
merged 4 commits into from Aug 16, 2023
Merged

Add missing docstrings #1234

merged 4 commits into from Aug 16, 2023

Conversation

WenzDaniel
Copy link
Collaborator

Adds missing doc-stings for some mini-analyses.

time range or data (see also further ).

In addition you can provide the following arguments:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W293 blank line contains whitespace

:param path: Relative path where the PDF should be stored. By default
it is the directory of the notebook.
:param detector_ending: Ending of the corresponding detector. Empty
string for TPC '_nv' for neutron-veto and '_mv' muon-veto.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W291 trailing whitespace

time range or data (see also further ).

In addition you can provide the following arguments:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W293 blank line contains whitespace

:param path: Relative path where the PDF should be stored. By default
it is the directory of the notebook.
:param detector_ending: Ending of the corresponding detector. Empty
string for TPC '_nv' for neutron-veto and '_mv' muon-veto.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W291 trailing whitespace

time range or data (see also further ).

In addition you can provide the following arguments:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W293 blank line contains whitespace

:param path: Relative path where the PDF should be stored. By default
it is the directory of the notebook.
:param detector_ending: Ending of the corresponding detector. Empty
string for TPC '_nv' for neutron-veto and '_mv' muon-veto.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W291 trailing whitespace

@coveralls
Copy link

coveralls commented Aug 11, 2023

Coverage Status

coverage: 93.556% (+0.02%) from 93.534% when pulling 5444c3a on add_doc_string_pulse_plots into 9a53370 on master.

Copy link
Contributor

@JYangQi00 JYangQi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Daniel, these docstrings read pretty clearly to me and I see now issues with merging.

@WenzDaniel WenzDaniel merged commit f58e19d into master Aug 16, 2023
7 checks passed
@WenzDaniel WenzDaniel deleted the add_doc_string_pulse_plots branch August 16, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants