New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SR1 offline simulation strax context #1253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @shenyangshi, it looks good to me, with a couple of comments for the future:
- I wonder if, although ugly (as is already the case), we could have integrated this new context options in the existing structure of
xenonnt_simulation
, since anyway the final usable context goes into cutax, - We need to study the simulations case scenarios and rethink the (effectively deprecated) options to jump from processing to simulation configs and back, i.e., the current
cmt_run_id_sim=None,
cmt_run_id_proc=None,
cmt_version='global_ONLINE',
fax_config='fax_config_nt_design.json',
overwrite_from_fax_file_sim=False,
overwrite_from_fax_file_proc=False,
...
Let's anyway not complicate our lifes for the moment :) I'll let @dachengx merge.
Hi @ramirezdiego, thanks! I indeed thought about rewriting the xenonnt_simulation, but I don't want to break existing code that uses the cmt options a lot. About the extra kwargs, I also thought about including them in the new context, but the namings are complex and even I cannot remember which is which. Maybe a better idea of the same comlexity is to modify st.config directly after setting up the context. |
I agree that we should keep the old simulation context unchanged, because of the backward compatibility requirement. |
@shenyangshi Can this new context also be used on SR0? |
Yes it can, if you give a SR0 run id and pick the SR0 fax_config. |
Hi @dachengx. Can we merge this and release v2.1.3 today? |
Would you add tests of the new context? Like: straxen/tests/test_contexts.py Line 140 in a1eadc4
|
@dachengx I think you can merge now. |
Will merge if the test passes. Will release v2.1.3 if this is merged today. |
Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
What does the code in this PR do / what does it improve?
Create a xedocs based simulation context using the exact corrections as real data. Simplify the logics.
Can you briefly describe how it works?
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:
Notes on testing
All italic comments can be removed from this template.