FDC uses corrected position

[shenyangshi]

See https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenonnt:analysis:signals_and_detector:20230815:fdc, now straxen uses original positions for the FDC correction but the map is developed for z_dv_corr.

Note that the SR0 result won't be affected as the z_bias_map in SR0 is a dummy map so z_corr=0.

I also delete some fields that don't make sense to me.

[shenyangshi]

The change is minimal, but the logic will be consistent.

[dachengx]

The change is minimal, but the logic will be consistent.

What is the data here?

[shenyangshi]

It's 043256 with the master branch of straxen and global_v12 correction https://github.com/XENONnT/corrections/pull/219

[dachengx]

So can we explain the difference of r in your demo by the change from z_naive to z_dv_corr? Do we actually expect a change, or is the reason for the change only digital precision?

[shenyangshi]

I don't know, something is not fully reproducible, but the change is negligible.

[shenyangshi]

Do you want to do a test by yourself? Corrections and versions in my folder are changing rapidly, I cannot promise I didn't make any stupid mistake in checking.

[dachengx]

Using environment:

^ Awesome table ^^^^
^ module ^ version ^ path ^ git ^
| python | 3.9.17 | /opt/XENONnT/anaconda/envs/XENONnT_2023.07.2/bin/python | None |
| strax | 1.5.3 | /home/xudc/strax/strax | branch:master | a466a94 |
| straxen | 2.1.2 | /home/xudc/straxen/straxen | branch:correct_fdc | f2f8825 |
| cutax | 1.15.3 | /home/xudc/cutax/cutax | branch:master | 4aa29c9 |

and code

run_id = '043256'

st = cutax.xenonnt_offline()

st.set_config(
    {'fdc_map': 'itp_map://resource://'
     'XnT_3D_FDC_xyz_MLP_v1.2_B2d75n_C2d74n_G0d3p_A5d0p_T0d9n_PMTs1d3n_FSR0d65p.json.gz'
     '?fmt=json.gz&scale_coordinates=plugin.coordinate_scales'}
)

EventPositions0 = st.get_single_plugin(run_id, 'event_positions')

I get

[dachengx]

And I do not think you should use &scale_coordinates=plugin.coordinate_scales.

[shenyangshi]

Yes indeed there is some change... Maybe due to interpolation errors. We don't have to use &scale_coordinates=plugin.coordinate_scales if the map itself is in z but not in drift time, but unfortunately in my reprocessings the url config has this, so I have to make the samething in the new plugin to compare.

[dachengx]

Then please check a bit. :)

[jingqiangye]

Hey I did some checks and it looks good to me.

[dachengx]

Hey I did some checks and it looks good to me.

Professional!