New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct elife at the last in corrected_areas
#1258
Conversation
Using
The difference on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dacheng. Indeed, I loaded the same run and most events now have non-nan values for cs2_area_fraction_top
, except for 6 events which I believe to be blinded events. I also use xedocs to set config and the photoionization correction is as expected. The code looks much cleaner.
I thinkcs2_area_fraction_top
and cs2_area_fraction_top_wo_elifecorr
are always the same, also true for cs2_area_fraction_top_wo_timecorr
and cs2_area_fraction_top_wo_picorr
, but I guess it's more convenient to have all values there so analysts are not required to know all of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the description of cs2_wo_* is consistent with code. Very good!
You can also check the readthedocs: https://straxen--1258.org.readthedocs.build/en/1258/reference/datastructure_nT.html#corrected-areas |
The left caveat is that we should also update |
What does the code in this PR do / what does it improve?
We corrected PI after elife in #1247, so that got a lot of nan
cs2_area_fraction_top
.Can you briefly describe how it works?
Now we correct the cS2 in the order of:
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable: