Pull out FakeDAQ to legacy plugins #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Should be merged together with: AxFoundation/strax#776 |
chnlkx
reviewed
Nov 22, 2023
JelleAalbers
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Sounds good; raw_records_diagnostic does not exist anymore so this clearly doesn't belong with the nT plugins.
Sorry @chnlkx, didn't see you reviewed already! Good think you checked the plugin can still be accessed (though I doubt anyone is still using it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the code in this PR do / what does it improve?
Move Fake1TDAQ into legacy plugins to not register in nT context.