add_ref_mon_nv_plugin #1307
Merged
add_ref_mon_nv_plugin #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…nto add_ref_mon_nv
WenzDaniel
reviewed
Dec 20, 2023
| time_unique_split = np.split(time_unique, np.where(time_diff >= split_time)[0]) | ||
| trigger_times = np.array([i[0] for i in time_unique_split]) | ||
|
|
||
| # split the hits in trigger windows |
There was a problem hiding this comment.
FYI: For splitting things by some container you can also use strax.split_by_containment or strax.fully_contained_in. Could be that those functions are faster if performance is an issue.
There was a problem hiding this comment.
It should be not a problem, but for future upgrades I could also test strax functions to see improvements. Thanks a lot!
|
I fixed a small import error, and test processed run |
|
and removed some not needed imports |
WenzDaniel
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the code in this PR do / what does it improve?
The code in this PR introduce a new plugin which computes parameters used for the Reflectivity Monitor for the Neutron Veto
Can you briefly describe how it works?
From the raw records, the start time of each trigger window is extracted (by taking the smallest "time" of all the channels)
Using the hitlets, the delta times wrt the beginning of the trigger are computed.
Cuts can be made in area (of all the hitlets), time (since the beginning of the trigger window) and number of contributing PMTs (in each window).
The returned values are the delta times (used for the reflectivity), PMT channels and areas.