New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S2(x,y) implementation via CMT #382
Conversation
…dd S2(x,y) map implementation vi CMT
reinstate the 1T options, overwrite for nT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Aaron, looks good. Have you checked a couple of run-number in the online version to double check the files returned are always correct?
Yes, I know why you are asking this ..LOL.. see blocks 6-8 in the example https://github.com/XENONnT/analysiscode/blob/master/corrections/Example_S2_map_implementation.ipynb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through the code and how exactly the corrections is calculated (order and used variables). Looks good. I will ask for a documentation of the review of this S2(x,y) map in corrections.
Thanks!
Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
What is the problem / what does the code in this PR do
S2(x,y) Implementation via CMT
Can you briefly describe how it works?
Please look at this example https://github.com/XENONnT/analysiscode/blob/master/corrections/Example_S2_map_implementation.ipynb
Can you give a minimal working example (or illustrate with a figure)?
Please look at this example https://github.com/XENONnT/analysiscode/blob/master/corrections/Example_S2_map_implementation.ipynb
Please include the following if applicable:
Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).