Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2(x,y) implementation via CMT #382

Merged
merged 11 commits into from Feb 25, 2021
Merged

S2(x,y) implementation via CMT #382

merged 11 commits into from Feb 25, 2021

Conversation

ahiguera-mx
Copy link
Contributor

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What is the problem / what does the code in this PR do
S2(x,y) Implementation via CMT

Can you briefly describe how it works?
Please look at this example https://github.com/XENONnT/analysiscode/blob/master/corrections/Example_S2_map_implementation.ipynb
Can you give a minimal working example (or illustrate with a figure)?
Please look at this example https://github.com/XENONnT/analysiscode/blob/master/corrections/Example_S2_map_implementation.ipynb
Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

Copy link
Contributor

@JoranAngevaare JoranAngevaare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aaron, looks good. Have you checked a couple of run-number in the online version to double check the files returned are always correct?

@ahiguera-mx
Copy link
Contributor Author

Thanks Aaron, looks good. Have you checked a couple of run-number in the online version to double check the files returned are always correct?

Yes, I know why you are asking this ..LOL.. see blocks 6-8 in the example https://github.com/XENONnT/analysiscode/blob/master/corrections/Example_S2_map_implementation.ipynb

Copy link
Member

@l-althueser l-althueser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through the code and how exactly the corrections is calculated (order and used variables). Looks good. I will ask for a documentation of the review of this S2(x,y) map in corrections.

Thanks!

@JoranAngevaare JoranAngevaare merged commit a17cf14 into XENONnT:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants