Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed nveto splitting thresholds. #490

Merged
merged 4 commits into from May 20, 2021

Conversation

WenzDaniel
Copy link
Contributor

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible

What is the problem / what does the code in this PR do
As discussed in this note we are setting the splitting thresholds to some initial reasonable values.

@skazama
Copy link
Contributor

skazama commented May 17, 2021

Hi Daniel, thanks for the PR. Can you tell me which plots in your wiki directly indicate that min_split_nv of 0.063 and min_split_ratio_nv of 0.75 are the best values for this tuning?

@JoranAngevaare JoranAngevaare merged commit 428933b into master May 20, 2021
@JoranAngevaare JoranAngevaare deleted the nveto_splitting_thresholds branch May 20, 2021 07:48
@JoranAngevaare JoranAngevaare changed the title Changed splitting thresholds. Changed nveto splitting thresholds. May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants