Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set check_broken=False for RucioFrontend.find #749

Merged
merged 2 commits into from Nov 11, 2021
Merged

Set check_broken=False for RucioFrontend.find #749

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3eb366
Set check_broken=False for RucioFrontend.find
ershockley Nov 6, 2021
031b2fc
Merge branch 'master' into rucio_find
JoranAngevaare Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions straxen/rucio.py
View file
Open in desktop
Expand Up @@ -122,6 +122,13 @@ def _find(self, key: strax.DataKey, write, allow_incomplete, fuzzy_for, fuzzy_fo

raise strax.DataNotAvailable

def find(self, key: strax.DataKey,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
D102 Missing docstring in public method

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
WPS612 Found useless overwritten method: find

write=False,
check_broken=False,
allow_incomplete=False,
fuzzy_for=tuple(), fuzzy_for_options=tuple()):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
C408 Unnecessary tuple call - rewrite as a literal.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
WPS404 Found complex default value

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
C408 Unnecessary tuple call - rewrite as a literal.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
WPS404 Found complex default value

return super().find(key, write, check_broken, allow_incomplete, fuzzy_for, fuzzy_for_options)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
E501 line too long (101 > 100 characters)


def get_rse_prefix(self, rse):
if HAVE_ADMIX:
prefix = admix.rucio.get_rse_prefix(rse)
Expand Down