New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for modifications to ONLINE permisions #113
Conversation
Hello @LuisSanchez25, I would be happy to help with the review of this PR, but I need more information. Could you please elaborate more? Is this useful for moving from CMT to xedocs for online processing (e.g., gain model)? Is there any hands-on example to help you understand architecture better? |
Hey Giovanni. So all this piece of code is doing is checking for a spesific user. In this case the corrections expert user, and ensuring then if they try to upload a correction this correction can only have the value "ONLINE" for version. The reason there are so many lines of code to achive something relatively simple is because I had to take into account all possible formats in which corrections could be inserted into xedocs. This change is aimed at preventing people from uploading the wrong data to the database and causing potential issues. |
Hey @LuisSanchez25, |
Hey Giovanni, thanks I will change that in the notebook in a separate PR |
I have tested the PR from the login node as follows:
If I try to insert in straxen_db() I have (as expected since I am not authorized) an error:
It looks good to me; however, could you please specify in the example which partition the notebook should be executed on? Since grand does not have an internet connection, the insert_docs wants to work. |
The purpose of this pull request is to only allow a particular user to insert ONLINE corrections and no others to protect the integrity of the database. This is not a full proof way of preventing this but it should at least prevent people from changing the database accidentally. We should update everyone to a new version of xedocs before giving out the new username and password