Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2.0] Difference in the Energy balance and level #405

Closed
BeReal86 opened this issue Oct 27, 2020 · 1 comment
Closed

[3.2.0] Difference in the Energy balance and level #405

BeReal86 opened this issue Oct 27, 2020 · 1 comment
Assignees
Labels
Bug Issues that is an error, bug or it is not working as expected Fixed Issues that after being labeled as Bug have been resolved
Milestone

Comments

@BeReal86
Copy link
Member

BeReal86 commented Oct 27, 2020

@LucasKovacs
Except for the issue that @FGServers stated. There is only 1 unit of difference in the Energy balance part.

metal

Crystal

deu

fusion

solar

#374 (comment)

Originally posted by @BeReal86 in #374 (comment)

@BeReal86 BeReal86 changed the title Difference in the Energy balance and level [3.2.0] Difference in the Energy balance and level Oct 27, 2020
@BeReal86 BeReal86 added the Bug Issues that is an error, bug or it is not working as expected label Oct 27, 2020
@duhow
Copy link
Contributor

duhow commented Nov 16, 2020

if ($this->_element_id >= 4) {
$Prod[4] = ProductionLib::productionAmount($energy_prod, $engineer_boost, 0, true);
} else {
$Prod[4] = ProductionLib::productionAmount($energy_prod, 1, 0, true);
}

Having $energy_prod as a float, here it does floor to upper values, which causes the issue.
Check Metal mine values before processing as an example:

float(-4037.878210982)
float(-4600.2969617973)
float(-5234.8206806659)
float(-5950.2461736903)
float(-6756.4085585128)
float(-7664.300958563)
float(-8686.2077530381)
float(-9835.8528968225)
float(-11128.564991833)
float(-12581.460976878)
float(-14213.650509014)
float(-16046.463337808)
float(-18103.70222727)
float(-20411.924261247)
float(-23000.753679747)

duhow added a commit to duhow/XG-Proyect-v3.x.x that referenced this issue Nov 16, 2020
LucasKovacs added a commit that referenced this issue Nov 17, 2020
@LucasKovacs LucasKovacs added the Fixed Issues that after being labeled as Bug have been resolved label Nov 17, 2020
@LucasKovacs LucasKovacs added this to the v3.3.0 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues that is an error, bug or it is not working as expected Fixed Issues that after being labeled as Bug have been resolved
Projects
None yet
Development

No branches or pull requests

3 participants