Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase column width for telegram direction #85

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

spacegaier
Copy link
Contributor

Currently in German (and possibly also other long languages) the text for the telegram direction gets cut off and there is more than enough space around it to make the column wider.

Only downside is on mobile, but for that use case the table should anyway be enhanced to then display rows that use two lines (as the HA frontend in general does).

image

Copy link
Member

@marvin-w marvin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. This column is hidden anyway on mobile.

@marvin-w
Copy link
Member

marvin-w commented Jun 24, 2023

Out of curiosity: Do you have some example code (or a link) for the "2 line" data table? I believe it would look much better.

@marvin-w marvin-w merged commit f491687 into XKNX:main Jun 24, 2023
2 checks passed
@spacegaier
Copy link
Contributor Author

Out of curiosity: Do you have some example code (or a link) for the "2 line" data table? I believe it would look much better.

https://github.com/home-assistant/frontend/blob/76490cc69007d3f40c067f6e8398dfcc16fa2f92/src/panels/config/blueprint/ha-blueprint-overview.ts#L125

@spacegaier spacegaier deleted the patch-1 branch June 24, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants